Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WebCrypto to be tread safe: part 2 #76

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Apr 17, 2024

What?

This is a continuation of the #75

This change centralizes and unifies logic and ensures that runtime (tr) isn't used outside the event loop.

I also removed references to WebCrypto steps, like (1., 2., etc.) since the issue is that for different algorithms, they could mean different steps, which could confuse future maintainers.

Why?

Closes #71

@olegbespalov olegbespalov self-assigned this Apr 17, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner April 17, 2024 15:53
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team April 17, 2024 15:53
@olegbespalov olegbespalov merged commit b51964d into main Apr 22, 2024
10 checks passed
@olegbespalov olegbespalov deleted the refactor/tread-safe-2 branch April 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from the direct runtime access throw the go routines
3 participants